Replace getMongoData.js legacy mongo shell script with mongoWellnessChecker.js script for new mongosh shell #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Apr 12, 2024
Co-authored-by: Anna Henningsen <[email protected]>
…age with no other diagnostic information. FixSummary: replaced "throw(..)" with "throw new Error(..)". This change helps the outermost try catch block to function correctly because it needs the e.message property to exist.
|
added two more fixes to the script so it aborts gracefully with more diagnostic information in cases where the database user executing the script does not have full permissions. |
|
For now we are going to keep getMongoData.js in addition to this script to support legacy mongo shell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new script which replicates the functionality of the existing getMongoData.js legacy mongo shell script. The new script provides the same functionality and output but is written using a modern mongosh shell program.
Changes introduced:
To verify the correctness of the new script, we have run a series of tests that cover all functions of the legacy script.
The rationale for creating a duplicate instead of refactoring the original script is to ensure a smooth transition and avoid potential service disruptions.